Conversation
Just so we can compile and test! Some things might/will not work. SPI and UART baud detect need to be looked at.
When passing the PR to this branch, it seems that the change to this line was forgotten.
Basic version of Arduino's I2S library. We currently support only 16bps + 16000 Hz sampling frequency. Other bitrates and sample rates will print warning and continue to operate, however the resulting audio quality may be poor. There will be further effort to fix these issues.
took me a while
Contributor
It's |
* [Docs] Added/Updated Lib builder docs * [Docs] Fixes according to the PR review * [Docs] Fixes according to the PR review
ESP32-S3 SDMMC support
Rainmaker - CmakeList.txt + src files edit
Requires manual reboot back into the new firmware after flashing has finished
Contributor
2 tasks
Includes support for SDMMC, LCD, LEDs, Buttons, Power and USB Switch
* feather esp32-s3 hardware definition and bootloader * fix bootloader addr (!?) * fix esp32s2 bootloader to latest version with right url and favvvvvicon * add qt py, simplify menus by removing flash size (fixed 8mb), psram (disabled) and upload (usb mode only) * add qtpy variant * remove flash interface type (upload dio, boot qio) * finish qtpy s3 definition
1 task
|
Have you really tested your code? I tested almost all examples, they could not pass compiling process. I tried Arduino IDE 1.8 and 2.0 separately with latest arduino ESP32 core 2.07 and 2.04. |
|
I don't see how this code can possibly work with the ESP32-S3. You need to specify I2S pins for the S3 since there are no defaults. You can use almost any pin you want for I2S on an ESP32-S3. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.